Skip to content

Conversation

@de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 21, 2025

Fixes #1128.

Description

API for setting hottier fails as request expects the fields used_size and `available_size, which it should not.

How to Verify

  1. Start parseable instance
  2. Try to create hottier in UI/API

Before: request fails, now it doesn't


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@de-sh de-sh requested a review from Koustavd18 January 21, 2025 06:41
@coveralls
Copy link

coveralls commented Jan 21, 2025

Pull Request Test Coverage Report for Build 12931641203

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 12.786%

Totals Coverage Status
Change from base Build 12929388721: 0.0%
Covered Lines: 2446
Relevant Lines: 19131

💛 - Coveralls

Copy link

@Koustavd18 Koustavd18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitisht nitisht merged commit a140d37 into parseablehq:main Jan 24, 2025
11 checks passed
@de-sh de-sh deleted the hottier-fix branch January 24, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: cannot set HotTier

4 participants