Skip to content

Conversation

@de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 8, 2025

Fixes #XXXX.

Description

This has been in the works for long, finally figured out how to simplify the flow and get rid of the "junk" code involving unnecessary arg matching(totally my opinion), but this I believe is a readability win for the CLI and should allow us to work on further modularizing the codebase. It still needs a bit of testing to ensure parity with previous implementation.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Jan 8, 2025

Pull Request Test Coverage Report for Build 12753670183

Details

  • 1 of 202 (0.5%) changed or added relevant lines in 37 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.3%) to 12.684%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/about.rs 0 1 0.0%
src/handlers/http/llm.rs 0 1 0.0%
src/handlers/http/mod.rs 0 1 0.0%
src/handlers/http/modal/ingest_server.rs 0 1 0.0%
src/handlers/http/modal/utils/logstream_utils.rs 0 1 0.0%
src/handlers/http/oidc.rs 0 1 0.0%
src/handlers/http/query.rs 0 1 0.0%
src/query/mod.rs 0 1 0.0%
src/utils/arrow/flight.rs 0 1 0.0%
src/alerts/mod.rs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/handlers/http/modal/mod.rs 1 31.65%
src/audit.rs 1 0.0%
src/cli.rs 6 0.0%
Totals Coverage Status
Change from base Build 12753189913: 0.3%
Covered Lines: 2408
Relevant Lines: 18985

💛 - Coveralls

Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nitisht nitisht merged commit ba932ac into parseablehq:main Jan 14, 2025
6 checks passed
parmesant pushed a commit to parmesant/parseable that referenced this pull request Jan 15, 2025
als fix Kafka `SslProtocol` parsing

---------

Co-authored-by: Nikhil Sinha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants