Skip to content

chore: update deps and improve readability of Cargo.toml #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 8, 2025
Merged

chore: update deps and improve readability of Cargo.toml #1075

merged 9 commits into from
Jan 8, 2025
+368 −227

Conversation

@de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 6, 2025

Fixes #XXXX.

Description

Updates datafusion to v44.0.0(changelog: v43.0.0, v44.0.0) and object_store to v0.11.2(changelog).

As a maintainability improvement this PR also organizes the crates according to usage.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@de-sh de-sh mentioned this pull request Jan 6, 2025
Merged
3 tasks
@coveralls
Copy link

coveralls commented Jan 6, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12669074305

Details

  • 10 of 18 (55.56%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 12.388%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/query/mod.rs 0 1 0.0%
src/query/stream_schema_provider.rs 0 1 0.0%
src/storage/azure_blob.rs 0 2 0.0%
src/storage/localfs.rs 0 2 0.0%
src/storage/s3.rs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/storage/localfs.rs 1 0.0%
Totals Coverage Status
Change from base Build 12669046191: 0.04%
Covered Lines: 2415
Relevant Lines: 19494
💛 - Coveralls

@de-sh de-sh marked this pull request as ready for review January 7, 2025 14:50
@de-sh de-sh requested a review from nitisht January 7, 2025 14:50
@nitisht nitisht merged commit ae94e53 into parseablehq:main Jan 8, 2025
6 checks passed
@de-sh de-sh deleted the update-deps branch January 9, 2025 10:14
parmesant pushed a commit to parmesant/parseable that referenced this pull request Jan 13, 2025
@nitisht @parmesant
chore: update deps and improve readability of Cargo.toml (parseable…
c3d8861 
…hq#1075)

* chore: update datafusion to v44.0.0

* chore: update `object_store` to v0.11.2

Fixes included are mentioned in https://github.com/alamb/arrow-rs/blob/de87e2e7c0c9f4e3f8fe120c803ee3c0cb38f1d4/object_store/CHANGELOG.md

* style: organize deps better for maintainability

* style: fmt dep

* ci: use compatible version of rust

* chore: up MSRV to 1.83.0

---------

Signed-off-by: Nitish Tiwari <[email protected]>
Co-authored-by: Nitish Tiwari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nitisht nitisht Awaiting requested review from nitisht

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@de-sh @coveralls @nitisht