Skip to content

fix: refactor ingestion #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix: refactor ingestion #1073

merged 1 commit into from
Jan 7, 2025

Conversation

@nikhilsinhaparseable
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable commented Jan 6, 2025

update ingestion flow to flatten only once
improve readability

@nikhilsinhaparseable
fix: refactor ingestion
7633ab2 
update ingestion flow to flatten only once
improve readability
@coveralls
Copy link

coveralls commented Jan 6, 2025

Pull Request Test Coverage Report for Build 12631243990

Details

  • 46 of 92 (50.0%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 11.78%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers/http/ingest.rs 43 45 95.56%
src/handlers/http/modal/utils/ingest_utils.rs 2 46 4.35%
Files with Coverage Reduction New Missed Lines %
src/handlers/http/modal/utils/ingest_utils.rs 2 25.17%
Totals Coverage Status
Change from base Build 12631108531: -0.1%
Covered Lines: 2312
Relevant Lines: 19627
💛 - Coveralls

@nitisht nitisht merged commit e4e0ae5 into parseablehq:main Jan 7, 2025
9 checks passed
parmesant pushed a commit to parmesant/parseable that referenced this pull request Jan 13, 2025
@nikhilsinhaparseable @parmesant
fix: refactor ingestion (parseablehq#1073)
f57759b 
update ingestion flow to flatten only once
improve readability

Fixes parseablehq#1064
@nikhilsinhaparseable nikhilsinhaparseable deleted the convert-array-to-object branch July 12, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parmesant parmesant Awaiting requested review from parmesant

1 more reviewer

@de-sh de-sh de-sh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nikhilsinhaparseable @coveralls @de-sh @nitisht