Schema merge #1008
Merged
Schema merge #1008
+17
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
current: querier checks if schema is available in STREAM_INFO if not, create schema from storage, load in STREAM_INFO and return STREAM_INFO cannot guarantee the latest state of the schema for distributed fix: merge schema from all ingestors and queriers and then load in STREAM_INFO and return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: get schema for distributed
current: querier checks if schema is available in STREAM_INFO
if not, create schema from storage, load in STREAM_INFO and return
still, because of long running ingestions, querier's STREAM_INFO cannot guarantee the latest state of the schema for distributed
fix: merge schema from all ingestors and queriers and then load in STREAM_INFO and return