fix: port 80 ignored in ingestor endpoint #1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
current state -
if ingest node starts at port 80 i.e.
if env vars P_ADDR or P_INGESTOR_ENDPOINT are set with port 80
server ignores the port and panics at start with error
fix -
if port is ignored, use default port to 80
de-sh
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current state -
if ingest node starts at port 80 i.e.
if env vars P_ADDR or P_INGESTOR_ENDPOINT are set with port 80
server ignores the port and panics at start with error
fix -
if port is ignored, use default port to 80