Skip to content

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Dec 8, 2024

Pull Request

Issue

Some MongoDB version ranges for tests that are using it_only_mongodb_version do not use valid semver version ranges. Therefore these tests are skipped via xit for certain MongoDB versions even though they should run.

Example:

Invalid disjoint range: <5.1>=6 should be <5.1 || >=6
Invalid closed range: >=5.1<6 should be >=5.1 <6 (missing space)

Approach

  • Fix invalid range strings.
  • Make it_only_mongodb_version and similar methods more robust by failing test with Error: Invalid version range on invalid version range.
  • Remove unnecessary convenience methods like fit_exclude_node_version which is just fit_only_node_version with the inverse version range.

Tasks

  • Adapt tests to pass for MongoDB 8

@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 8, 2024

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@codecov
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.51%. Comparing base (6146777) to head (1774f8d).
Report is 14 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #9474      +/-   ##
==========================================
+ Coverage   93.50%   93.51%   +0.01%     
==========================================
  Files         186      186              
  Lines       14810    14810              
==========================================
+ Hits        13848    13850       +2     
+ Misses        962      960       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza merged commit d097929 into parse-community:alpha Dec 9, 2024
30 checks passed
@mtrezza mtrezza deleted the ci/fix-invalid-mongodb-version-ranges branch December 9, 2024 00:19
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.4.0-alpha.7

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released-alpha Released as alpha version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants