Skip to content

Conversation

@mkmandar123
Copy link
Contributor

@mkmandar123 mkmandar123 commented Jul 5, 2024

Pull Request

Issue

Change in data of the object from beforeSave to afterSave hook.

Closes: #9176

Approach

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jul 5, 2024

Thanks for opening this pull request!

@mtrezza mtrezza changed the title Bug: Object data type change from beforeSave to afterSave hook trigger. fix: Object data type change from beforeSave to afterSave hook trigger. Jul 8, 2024
@mtrezza mtrezza changed the title fix: Object data type change from beforeSave to afterSave hook trigger. fix: Object data type change from beforeSave to afterSave hook trigger Jul 8, 2024
@mtrezza
Copy link
Member

mtrezza commented Jul 8, 2024

After the recent fixes in Parse Server, let's rebase and see if this test still fails...

Signed-off-by: Manuel <[email protected]>
Signed-off-by: Manuel <[email protected]>
@mtrezza
Copy link
Member

mtrezza commented Jul 8, 2024

Test passes; merging this PR to add the additional test to avoid regression and closing related issue.

@mtrezza mtrezza changed the title fix: Object data type change from beforeSave to afterSave hook trigger test: Object data type should not change from beforeSave to afterSave trigger Jul 8, 2024
@mtrezza mtrezza merged commit 1e21b69 into parse-community:alpha Jul 8, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.2.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jul 9, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-beta Released as beta version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Object data type change from beforeSave to afterSave hook trigger

3 participants