refactor: Remove deprecated bcrypt-nodejs package #8902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! |
cbaker6
commented
Jan 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #8902 +/- ##
==========================================
+ Coverage 93.82% 94.21% +0.38%
==========================================
Files 186 186
Lines 14797 14797
==========================================
+ Hits 13884 13941 +57
+ Misses 913 856 -57 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Ready for review... |
mtrezza
approved these changes
Feb 15, 2024
Contributor
|
🎉 This change has been released in version 7.0.0-alpha.19 |
Contributor
|
🎉 This change has been released in version 7.0.0-beta.1 |
Contributor
|
🎉 This change has been released in version 7.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Causes a warning during install,
npm WARN deprecated [email protected]: bcrypt-nodejs is no longer actively maintained. Please use bcrypt or bcryptjs. See https://github.com/kelektiv/node.bcrypt.js/wiki/bcrypt-vs-brypt.js to learn more about these two optionsCloses: #8903
Approach
Tasks