fix: Live query throws error when constraint notEqualTo is set to null
#8835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
Thanks for opening this pull request!
|
mtrezza
requested changes
Dec 16, 2023
Member
mtrezza
left a comment
mtrezza
left a comment
There was a problem hiding this comment.
Please revert the changes in package-lock.json
mtrezza
requested changes
Dec 16, 2023
Member
mtrezza
left a comment
mtrezza
left a comment
There was a problem hiding this comment.
This test does not expect anything, please add a check to the test
Contributor
Author
Actually, the server itself crashes since we are not handling the error thrown inside |
RahulLanjewar93
force-pushed
the
test-live-query-failing-for-notEqualTo-null
branch
from
e8137a6 to
cced89c
Compare
mtrezza
requested changes
Dec 16, 2023
RahulLanjewar93
changed the title
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
mtrezza
reviewed
Dec 16, 2023
mtrezza
reviewed
Dec 16, 2023
mtrezza
reviewed
Dec 16, 2023
Signed-off-by: Manuel <[email protected]>
Signed-off-by: Manuel <[email protected]>
Signed-off-by: Manuel <[email protected]>
mtrezza
reviewed
Dec 16, 2023
Signed-off-by: Manuel <[email protected]>
mtrezza
reviewed
Dec 16, 2023
Signed-off-by: Manuel <[email protected]>
mtrezza
reviewed
Dec 16, 2023
Signed-off-by: Manuel <[email protected]>
mtrezza
reviewed
Dec 16, 2023
Signed-off-by: Manuel <[email protected]>
Member
|
I believe the test looks good now; do you have any suggestion for a fix? |
Contributor
Author
parse-server/src/LiveQuery/QueryTools.js Line 226 in 2c2563e this line should have optional chaining in my opinion |
RahulLanjewar93
changed the title
notEqualTo is set to null
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #8835 +/- ##
=======================================
Coverage 94.15% 94.15%
=======================================
Files 186 186
Lines 14726 14726
=======================================
Hits 13865 13865
Misses 861 861 ☔ View full report in Codecov by Sentry. |
parseplatformorg
pushed a commit
that referenced
this pull request
Jun 11, 2024
# [7.1.0-alpha.10](7.1.0-alpha.9...7.1.0-alpha.10) (2024-06-11) ### Bug Fixes * Live query throws error when constraint `notEqualTo` is set to `null` ([#8835](#8835)) ([11d3e48](11d3e48))
Contributor
|
🎉 This change has been released in version 7.1.0-alpha.10 |
parseplatformorg
pushed a commit
that referenced
this pull request
Jun 30, 2024
# [7.1.0-beta.1](7.0.0...7.1.0-beta.1) (2024-06-30) ### Bug Fixes * `Parse.Cloud.startJob` and `Parse.Push.send` not returning status ID when setting Parse Server option `directAccess: true` ([#8766](#8766)) ([5b0efb2](5b0efb2)) * `Required` option not handled correctly for special fields (File, GeoPoint, Polygon) on GraphQL API mutations ([#8915](#8915)) ([907ad42](907ad42)) * Facebook Limited Login not working due to incorrect domain in JWT validation ([#9122](#9122)) ([9d0bd2b](9d0bd2b)) * Live query throws error when constraint `notEqualTo` is set to `null` ([#8835](#8835)) ([11d3e48](11d3e48)) * Parse Server option `extendSessionOnUse` not working for session lengths < 24 hours ([#9113](#9113)) ([0a054e6](0a054e6)) * Rate limiting can fail when using Parse Server option `rateLimit.redisUrl` with clusters ([#8632](#8632)) ([c277739](c277739)) * SQL injection when using Parse Server with PostgreSQL; fixes security vulnerability [GHSA-c2hr-cqg6-8j6r](GHSA-c2hr-cqg6-8j6r) ([#9167](#9167)) ([2edf1e4](2edf1e4)) ### Features * Add `silent` log level for Cloud Code ([#8803](#8803)) ([5f81efb](5f81efb)) * Add server security check status `security.enableCheck` to Features Router ([#8679](#8679)) ([b07ec15](b07ec15)) * Prevent Parse Server start in case of unknown option in server configuration ([#8987](#8987)) ([8758e6a](8758e6a)) * Upgrade to @parse/push-adapter 6.0.0 ([#9066](#9066)) ([18bdbf8](18bdbf8)) * Upgrade to @parse/push-adapter 6.2.0 ([#9127](#9127)) ([ca20496](ca20496)) * Upgrade to Parse JS SDK 5.2.0 ([#9128](#9128)) ([665b8d5](665b8d5))
Contributor
|
🎉 This change has been released in version 7.1.0-beta.1 |
parseplatformorg
pushed a commit
that referenced
this pull request
Jun 30, 2024
# [7.1.0](7.0.0...7.1.0) (2024-06-30) ### Bug Fixes * `Parse.Cloud.startJob` and `Parse.Push.send` not returning status ID when setting Parse Server option `directAccess: true` ([#8766](#8766)) ([5b0efb2](5b0efb2)) * `Required` option not handled correctly for special fields (File, GeoPoint, Polygon) on GraphQL API mutations ([#8915](#8915)) ([907ad42](907ad42)) * Facebook Limited Login not working due to incorrect domain in JWT validation ([#9122](#9122)) ([9d0bd2b](9d0bd2b)) * Live query throws error when constraint `notEqualTo` is set to `null` ([#8835](#8835)) ([11d3e48](11d3e48)) * Parse Server option `extendSessionOnUse` not working for session lengths < 24 hours ([#9113](#9113)) ([0a054e6](0a054e6)) * Rate limiting can fail when using Parse Server option `rateLimit.redisUrl` with clusters ([#8632](#8632)) ([c277739](c277739)) * SQL injection when using Parse Server with PostgreSQL; fixes security vulnerability [GHSA-c2hr-cqg6-8j6r](GHSA-c2hr-cqg6-8j6r) ([#9167](#9167)) ([2edf1e4](2edf1e4)) ### Features * Add `silent` log level for Cloud Code ([#8803](#8803)) ([5f81efb](5f81efb)) * Add server security check status `security.enableCheck` to Features Router ([#8679](#8679)) ([b07ec15](b07ec15)) * Prevent Parse Server start in case of unknown option in server configuration ([#8987](#8987)) ([8758e6a](8758e6a)) * Upgrade to @parse/push-adapter 6.0.0 ([#9066](#9066)) ([18bdbf8](18bdbf8)) * Upgrade to @parse/push-adapter 6.2.0 ([#9127](#9127)) ([ca20496](ca20496)) * Upgrade to Parse JS SDK 5.2.0 ([#9128](#9128)) ([665b8d5](665b8d5))
Contributor
|
🎉 This change has been released in version 7.1.0 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
failing Test case for issue #8834
adding this so pr is not closed. closes #8834