Skip to content

Remove limit when counting results. #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2016
Merged

Remove limit when counting results. #867

merged 1 commit into from
Mar 6, 2016

Conversation

@gfosco
Copy link
Contributor

@gfosco gfosco commented Mar 6, 2016

To address #625.

I'd rather not add a test which creates more than 100 objects...

@gfosco gfosco mentioned this pull request Mar 6, 2016
Closed
@codecov-io
Copy link

codecov-io commented Mar 6, 2016

Current coverage is 91.67%

Merging #867 into master will increase coverage by +0.01% as of a0b9454

@@            master    #867   diff @@
======================================
  Files           71      71       
  Stmts         4105    4106     +1
  Branches       846     846       
  Methods          0       0       
======================================
+ Hit           3763    3764     +1
  Partial         10      10       
  Missed         332     332

Review entire Coverage Diff as of a0b9454

Powered by Codecov. Updated on successful CI builds.

@flovilmart
Copy link
Contributor

flovilmart commented Mar 6, 2016

LGTM

gfosco added a commit that referenced this pull request Mar 6, 2016
@gfosco
Merge pull request #867 from ParsePlatform/fosco.count
3fb6a60 
Remove limit when counting results.
@gfosco gfosco merged commit 3fb6a60 into master Mar 6, 2016
@gfosco gfosco deleted the fosco.count branch March 6, 2016 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gfosco @codecov-io @flovilmart @facebook-github-bot