Skip to content

ci: Fix flaky definitions check #8504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 29, 2023
Merged

ci: Fix flaky definitions check #8504

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
57b9e74
Update definitionsCheck.js
dblythy Apr 12, 2023
2a712bc
Update definitionsCheck.js
dblythy Apr 12, 2023
48a45a8
Merge branch 'alpha' into fix-definitions
dblythy May 22, 2023
8d3f0b6
Merge branch 'alpha' into fix-definitions
dblythy May 29, 2023
276db63
Update definitionsCheck.js
dblythy May 29, 2023
aaa994c
Update ci.yml
dblythy May 29, 2023
6eba1ec
Update ci.yml
dblythy May 29, 2023
e61dfcf
Update ci.yml
dblythy May 29, 2023
a657a5c
Update definitionsCheck.js
dblythy May 29, 2023
a419a83
Update definitionsCheck.js
dblythy May 29, 2023
50e6646
Update definitionsCheck.js
dblythy May 29, 2023
64ac892
Update ci.yml
dblythy May 29, 2023
935a7f0
Update definitionsCheck.js
dblythy May 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions ci/definitionsCheck.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,14 @@
const fs = require('fs').promises;
const { exec } = require('child_process');
const core = require('@actions/core');
const { nextTick } = require('process');
const { AbortController } = require("node-abort-controller");
const util = require('util');
(async () => {
const [currentDefinitions, currentDocs] = await Promise.all([
fs.readFile('./src/Options/Definitions.js', 'utf8'),
fs.readFile('./src/Options/docs.js', 'utf8'),
]);
exec('npm run definitions');
const ac = new AbortController();
const { signal } = ac;
const watcher = fs.watch('./src/Options/docs.js', {signal});
let i = 0;
// eslint-disable-next-line
for await (const _ of watcher) {
i++;
if (i === 3) {
ac.abort();
break;
}
}
await new Promise(resolve => nextTick(resolve));
const execute = util.promisify(exec);
await execute('npm run definitions');
const [newDefinitions, newDocs] = await Promise.all([
fs.readFile('./src/Options/Definitions.js', 'utf8'),
fs.readFile('./src/Options/docs.js', 'utf8'),
Expand Down