Skip to content

Conversation

@dblythy
Copy link
Member

@dblythy dblythy commented Oct 12, 2022

New Pull Request Checklist

Issue Description

Related issue: n/a

Approach

Idempotency tests mutate DEFAULT_TIMEOUT_INTERVAL to 3 and a half minutes, so any tests thereafter will maintain that timeout. This means that if 3-5 tests timeout, the whole test suite will stop (as it's limited to 15 minutes).

This PR sets the timeout back to the default after the Idempotency tests.

TODOs before merging

  • Add tests
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Related issue: #123 in the PR description, so I can recognize it.

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 94.11% // Head: 94.11% // No change to project coverage 👍

Coverage data is based on head (624bc5f) compared to base (2b00c5b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #8227   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files         182      182           
  Lines       13770    13770           
=======================================
  Hits        12960    12960           
  Misses        810      810           
Impacted Files Coverage Δ
src/Adapters/Files/GridFSBucketAdapter.js 93.43% <0.00%> (-0.73%) ⬇️
src/RestWrite.js 94.78% <0.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Moumouls Moumouls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtrezza
Copy link
Member

mtrezza commented Oct 16, 2022

@dblythy is this ready for review?

@dblythy dblythy requested a review from a team October 16, 2022 23:29
@dblythy
Copy link
Member Author

dblythy commented Oct 16, 2022

Yes, apologies

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit 4af13af into parse-community:alpha Oct 16, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.3.0-alpha.30

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 17, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 29, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 19, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0

@parseplatformorg parseplatformorg added the state:released-5.x.x Released as LTS version label Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-5.x.x Released as LTS version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants