Skip to content

Conversation

@cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jan 2, 2022

New Pull Request Checklist

Issue Description

There are unnecessary error checks in PostgresStorageAdapter.js that were left over from adding IF NOT EXISTS in #6741 and #6506

Related issue: #6741 and #6506

Approach

Remove error checks and code that isn't used anymore.

TODOs before merging

  • Add tests
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 2, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #7761 (9f80210) into alpha (7af5de4) will increase coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            alpha    #7761      +/-   ##
==========================================
+ Coverage   93.96%   93.99%   +0.02%     
==========================================
  Files         183      183              
  Lines       13640    13635       -5     
==========================================
- Hits        12817    12816       -1     
+ Misses        823      819       -4     
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 95.86% <50.00%> (+0.36%) ⬆️
src/ParseServerRESTController.js 97.01% <0.00%> (-1.50%) ⬇️
src/RestWrite.js 94.04% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7af5de4...9f80210. Read the comment docs.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Jan 2, 2022

@mtrezza this is ready for review.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mtrezza mtrezza merged commit 5e363ea into parse-community:alpha Jan 2, 2022
@cbaker6 cbaker6 deleted the cleanPostgres branch January 2, 2022 17:44
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-alpha.16

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 2, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.10

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Mar 15, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants