Skip to content

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Feb 21, 2021

New Pull Request Checklist

Issue Description

Lint is currently executed in an anti-pattern that poses a high risk of not being executed in case of a name change of an unrelated test.

Related issue: (none, due to simply meta fix)

Approach

Moved lint to be a separate CI task, independent of other tests.

TODOs before merging

(none)

mtrezza and others added 19 commits November 19, 2020 01:05
* commit 'ccb045b68c5b4d983a90fa125513fc476e4e2387':
  fix: upgrade @graphql-tools/links from 6.2.4 to 6.2.5 (parse-community#7007)
  fix: upgrade pg-promise from 10.7.0 to 10.7.1 (parse-community#7009)
  fix: upgrade jwks-rsa from 1.10.1 to 1.11.0 (parse-community#7008)
  fix: upgrade graphql from 15.3.0 to 15.4.0 (parse-community#7011)
  update stale bot (parse-community#6998)
  fix(beforeSave/afterSave): Return value instead of Parse.Op for nested fields (parse-community#7005)
  fix(beforeSave): Skip Sanitizing Database results (parse-community#7003)
  Fix includeAll for querying a Pointer and Pointer array (parse-community#7002)
  Init (parse-community#6999)
* commit '7f47b0427ea56214d9b0199f0fcfa4af38794e02':
  Add page localization (parse-community#7128)
  Improve contribution guide (parse-community#7075)
  fix: upgrade pg-promise from 10.9.0 to 10.9.1 (parse-community#7170)
  Add tests against multiple MongoDB versions (parse-community#7161)
  fix: upgrade mime from 2.4.7 to 2.5.0 (parse-community#7166)
  fix: upgrade pg-promise from 10.8.7 to 10.9.0 (parse-community#7168)
  fix: upgrade apollo-server-express from 2.19.1 to 2.19.2 (parse-community#7165)
  Upgrade @node-rs/bcrypt to latest version (parse-community#7159)
  Run Prettier after Definitions (parse-community#7164)
@mtrezza mtrezza requested a review from dplewis February 21, 2021 23:32
@mtrezza
Copy link
Member Author

mtrezza commented Feb 21, 2021

Additionally, the "Lint" check should be marked as mandatory in the repo settings.

@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #7216 (c18a2ab) into master (f1394a9) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7216      +/-   ##
==========================================
- Coverage   94.01%   94.00%   -0.01%     
==========================================
  Files         172      172              
  Lines       12869    12869              
==========================================
- Hits        12099    12098       -1     
- Misses        770      771       +1     
Impacted Files Coverage Δ
src/Adapters/Files/GridFSBucketAdapter.js 79.50% <0.00%> (-0.82%) ⬇️
src/Controllers/DatabaseController.js 95.46% <0.00%> (-0.15%) ⬇️
src/RestWrite.js 94.00% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1394a9...9657f3f. Read the comment docs.

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll close mine.

@dplewis dplewis merged commit 6706558 into parse-community:master Feb 21, 2021
@mtrezza mtrezza deleted the improve-ci-lint branch February 21, 2021 23:41
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-beta Released as beta version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants