Improve test code #7121
Merged
Improve test code #7121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7121 +/- ##
==========================================
- Coverage 93.89% 93.88% -0.01%
==========================================
Files 169 169
Lines 12530 12530
==========================================
- Hits 11765 11764 -1
- Misses 765 766 +1
Continue to review full report at Codecov.
|
mtrezza
approved these changes
Jan 13, 2021
Member
mtrezza
left a comment
mtrezza
left a comment
There was a problem hiding this comment.
- There is/was a
rest_create_appendpoint? 😳 - Changing retry to 1 may also help to identify flaky tests easier.
Closed
Member
Author
|
@erencihangir Did you want to comment? |
rsouzas
pushed a commit
to back4app/parse-server
that referenced
this pull request
Jan 29, 2021
dplewis
added a commit
that referenced
this pull request
Feb 21, 2021
Contributor
|
🎉 This change has been released in version 5.0.0-beta.1 |
Contributor
|
🎉 This change has been released in version 5.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
I noticed that when you write failing tests sometime it fails 5 times which makes it difficult to pin point where to debug.
Also I noticed an extra parse instance getting created from what seems to be an old test file. (Wasted hours on this 😭 )
Related issue: #6644
Approach
Set network retry to 1 (Changed Promise.all to saveAll in Auth.spec.js to reduce load)
Remove strange file.
TODOs before merging