Skip to content

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Dec 18, 2020

New Pull Request Checklist

Issue Description

Node security link is outdated, npm does no longer triage vulnerabilities.
Related issue: closes parse-community/docs#796

Approach

Link removed.

TODOs before merge:

* commit 'ccb045b68c5b4d983a90fa125513fc476e4e2387':
  fix: upgrade @graphql-tools/links from 6.2.4 to 6.2.5 (parse-community#7007)
  fix: upgrade pg-promise from 10.7.0 to 10.7.1 (parse-community#7009)
  fix: upgrade jwks-rsa from 1.10.1 to 1.11.0 (parse-community#7008)
  fix: upgrade graphql from 15.3.0 to 15.4.0 (parse-community#7011)
  update stale bot (parse-community#6998)
  fix(beforeSave/afterSave): Return value instead of Parse.Op for nested fields (parse-community#7005)
  fix(beforeSave): Skip Sanitizing Database results (parse-community#7003)
  Fix includeAll for querying a Pointer and Pointer array (parse-community#7002)
  Init (parse-community#6999)
@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #7081 (46675be) into master (97c3046) will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7081      +/-   ##
==========================================
+ Coverage   93.63%   93.90%   +0.26%     
==========================================
  Files         169      169              
  Lines       12498    12535      +37     
==========================================
+ Hits        11703    11771      +68     
+ Misses        795      764      -31     
Impacted Files Coverage Δ
src/Config.js 90.96% <0.00%> (-0.50%) ⬇️
src/rest.js 98.86% <0.00%> (ø)
src/triggers.js 94.60% <0.00%> (ø)
src/Options/Definitions.js 100.00% <0.00%> (ø)
src/Adapters/PubSub/EventEmitterPubSub.js 100.00% <0.00%> (ø)
src/RestQuery.js 95.52% <0.00%> (+0.01%) ⬆️
src/cloud-code/Parse.Cloud.js 98.73% <0.00%> (+0.14%) ⬆️
src/RestWrite.js 93.84% <0.00%> (+0.16%) ⬆️
src/LiveQuery/QueryTools.js 94.68% <0.00%> (+0.63%) ⬆️
src/Controllers/LiveQueryController.js 96.55% <0.00%> (+0.71%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97c3046...46675be. Read the comment docs.

Copy link
Member

@Moumouls Moumouls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtrezza mtrezza marked this pull request as draft December 19, 2020 10:23
@mtrezza
Copy link
Member Author

mtrezza commented Dec 19, 2020

Changed to draft due to ongoing discussion about form.

@mtrezza mtrezza marked this pull request as ready for review January 22, 2021 22:16
Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davimacedo could you add the DNS record for this?

@davimacedo
Copy link
Member

Do you want me to create a DNS record from report.parseplatform.org to https://form.jotform.com/210205133587044, right? I am not sure if that's possible though. A CNAME from report.parseplatform.org to form.jotform.com is possible for sure, but you need also to check with form.jotform.com if you need to setup something in their side. I can also create a permanent redirect from https://report.parseplatform.org to https://form.jotform.com/210205133587044.

@mtrezza
Copy link
Member Author

mtrezza commented Jan 27, 2021

Yes, a redirect, sorry, custom domain feature is disabled in JotForm free version.
I also changed the form url to https://form.jotform.com/parseplatform/report-a-vulnerability, maybe that helps with SEO.

@davimacedo
Copy link
Member

Done. Could you please check it out?

@mtrezza
Copy link
Member Author

mtrezza commented Jan 29, 2021

Works fine! I think we can merge this one?

@davimacedo
Copy link
Member

Yes. I think we can.

@mtrezza
Copy link
Member Author

mtrezza commented Jan 29, 2021

I think someone should try out the form actually, whether it sends an email, I don't have access to the email account community@...

And if anyone wants to install the mobile app to get push notifications on form submits, I can give the Jotform credentials.

@TomWFox
Copy link
Contributor

TomWFox commented Jan 29, 2021

Just tested, email received

@TomWFox TomWFox merged commit 25fb576 into parse-community:master Jan 29, 2021
@mtrezza mtrezza deleted the fix-node-security-link branch January 29, 2021 18:20
dplewis pushed a commit that referenced this pull request Feb 21, 2021
* removed node security link

* improve PGP wording

* Added report form link

* removed PGP key
@mtrezza mtrezza mentioned this pull request Mar 4, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-beta Released as beta version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📙 Fix Node Security link

5 participants