Run Prettier JS #2 #6796
Merged
Run Prettier JS #2 #6796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davimacedo
approved these changes
Jul 13, 2020
Member
davimacedo
left a comment
davimacedo
left a comment
There was a problem hiding this comment.
It looks good. Let's just wait for the CI.
mtrezza
approved these changes
Jul 13, 2020
Member
mtrezza
left a comment
mtrezza
left a comment
There was a problem hiding this comment.
I like it, the space-after-function seems to be a minor question, looking at it by volume.
Codecov Report
@@ Coverage Diff @@
## master #6796 +/- ##
=======================================
Coverage 93.90% 93.91%
=======================================
Files 169 169
Lines 12054 12054
=======================================
+ Hits 11319 11320 +1
+ Misses 735 734 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove arrow parentheses for single argument arrow functions.