Add missing encodeURIComponent on username password reset #6278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks @Klaitos . Can you please add a test case as well? |
Codecov Report
@@ Coverage Diff @@
## master #6278 +/- ##
==========================================
- Coverage 93.85% 93.84% -0.01%
==========================================
Files 169 169
Lines 11564 11566 +2
==========================================
+ Hits 10853 10854 +1
- Misses 711 712 +1
Continue to review full report at Codecov.
|
Contributor
Author
Done ! |
dplewis
approved these changes
Dec 17, 2019
Member
dplewis
left a comment
dplewis
left a comment
There was a problem hiding this comment.
The test looks good! Thanks for contributing.
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
…unity#6278) * Add missing encodeURIComponent on username * Add new unit test on encoded username password reset redirect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6277
Here you go @davimacedo