Use Prettier JS #5017
Use Prettier JS #5017
Conversation
|
@acinader no more 'coding style' arguments! |
Codecov Report
@@ Coverage Diff @@
## master #5017 +/- ##
==========================================
- Coverage 94.28% 94.22% -0.06%
==========================================
Files 121 121
Lines 8728 8820 +92
==========================================
+ Hits 8229 8311 +82
- Misses 499 509 +10
Continue to review full report at Codecov.
|
| "prettier --write", | ||
| "flow", | ||
| "eslint --cache ./", | ||
| "git add" |
There was a problem hiding this comment.
@flovilmart a bad side effect of this change is that if you commit with unstaged changes, they'll actually get committed.
for the time being, I have just commented out this hunk from package.json.
There was a problem hiding this comment.
No they don’t only the list of files that are staged are passed as an argument.
Husky passes the list of files to the commandsz
There was a problem hiding this comment.
In my case, I staged part of a file, but it would end up committing all the changes in the file, not just the parts I staged.
There was a problem hiding this comment.
You’re right, still, this feels like a corner case
* Adds prettier * Run lint before tests
Because it's awesome!
It's also combined with pre-commit hooks so your code will always be pretty!