Skip to content

Conversation

@flovilmart
Copy link
Contributor

No description provided.

@flovilmart flovilmart requested a review from acinader August 19, 2018 13:41
@codecov
Copy link

codecov bot commented Aug 19, 2018

Codecov Report

Merging #4994 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4994      +/-   ##
==========================================
+ Coverage   94.24%   94.29%   +0.04%     
==========================================
  Files         121      121              
  Lines        8760     8760              
==========================================
+ Hits         8256     8260       +4     
+ Misses        504      500       -4
Impacted Files Coverage Δ
src/Adapters/Auth/httpsRequest.js 95.23% <0%> (-4.77%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 97.3% <0%> (+0.08%) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.07% <0%> (+0.74%) ⬆️
src/Routers/PushRouter.js 96.42% <0%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40d2cab...8ceec56. Read the comment docs.

acinader
acinader previously approved these changes Aug 19, 2018
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with a nit


### Push Configuration

Please provide a copy of you `push` configuration here, obfuscating any sensitive part.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'you' should be 'your'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@flovilmart flovilmart merged commit 786ea11 into master Aug 19, 2018
@flovilmart flovilmart deleted the flovilmart-patch-1 branch August 19, 2018 14:43
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Update ---push-notifications.md

* Update ---push-notifications.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants