Skip to content

Conversation

@flovilmart
Copy link
Contributor

@flovilmart flovilmart commented Jul 2, 2018

  • Adds watch to watch changes when running the test to regenerate
  • Tests are now pure node 8

@acinader what do you think? It shaves off 2 seconds of loading time, and you just need to run npm run watch alongside to regen the source in the lib folder.

- Adds watch to watch changes when running the test to regenerate
- Tests are now pure node 8
@flovilmart flovilmart force-pushed the no-babel-register branch from a768254 to 495cf2c Compare July 3, 2018 00:31
acinader
acinader previously approved these changes Jul 3, 2018
@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #4865 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4865      +/-   ##
==========================================
+ Coverage   92.83%   92.95%   +0.12%     
==========================================
  Files         119      119              
  Lines        8818     8815       -3     
==========================================
+ Hits         8186     8194       +8     
+ Misses        632      621      -11
Impacted Files Coverage Δ
src/Push/PushWorker.js 98.18% <ø> (+5.07%) ⬆️
src/Adapters/Storage/Mongo/MongoTransform.js 88.17% <0%> (+1.04%) ⬆️
src/Push/utils.js 100% <0%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e97df07...ad8d394. Read the comment docs.

@flovilmart flovilmart merged commit ae1a822 into master Jul 3, 2018
@flovilmart flovilmart deleted the no-babel-register branch July 3, 2018 03:30
flovilmart added a commit that referenced this pull request Aug 12, 2018
* Removes need to use babel-register

- Adds watch to watch changes when running the test to regenerate
- Tests are now pure node 8

* Adds timing to helper.js

* Update contribution guide

* Adds inline sourcemaps generation to restore coverage

* nits
flovilmart added a commit that referenced this pull request Aug 12, 2018
* Removes need to use babel-register

- Adds watch to watch changes when running the test to regenerate
- Tests are now pure node 8

* Adds timing to helper.js

* Update contribution guide

* Adds inline sourcemaps generation to restore coverage

* nits
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* Removes need to use babel-register

- Adds watch to watch changes when running the test to regenerate
- Tests are now pure node 8

* Adds timing to helper.js

* Update contribution guide

* Adds inline sourcemaps generation to restore coverage

* nits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants