refactoring method createClass #4465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing error-analysis conditions that are irrelevant, i.e. since we are only returning the batch, the error will always have `data` set to the size of the input array, as per [the library's API](http://vitaly-t.github.io/spex/errors.BatchError.html).
removing the use of the default separator.
Codecov Report
@@ Coverage Diff @@
## master #4465 +/- ##
==========================================
- Coverage 92.72% 92.69% -0.03%
==========================================
Files 118 118
Lines 8356 8356
==========================================
- Hits 7748 7746 -2
- Misses 608 610 +2
Continue to review full report at Codecov.
|
Contributor
Author
|
@flovilmart should be good to go? 😉 |
Contributor
|
It looks good! Good thinking with the default join :) |
flovilmart
approved these changes
Dec 28, 2017
flovilmart
pushed a commit
that referenced
this pull request
Dec 29, 2017
* refactoring method createClass Removing error-analysis conditions that are irrelevant, i.e. since we are only returning the batch, the error will always have `data` set to the size of the input array, as per [the library's API](http://vitaly-t.github.io/spex/errors.BatchError.html). * Update PostgresStorageAdapter.js removing the use of the default separator.
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
* refactoring method createClass Removing error-analysis conditions that are irrelevant, i.e. since we are only returning the batch, the error will always have `data` set to the size of the input array, as per [the library's API](http://vitaly-t.github.io/spex/errors.BatchError.html). * Update PostgresStorageAdapter.js removing the use of the default separator.
This was referenced Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing error-analysis conditions that are irrelevant, i.e. since we are only returning the batch, the error will always have
dataset to the size of the input array, as per the library's API.In addition, removed the use of the default separator
','forArray.joinmethod everywhere.