Update mongodb to the latest version 🚀 #4449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4449 +/- ##
=========================================
- Coverage 92.98% 92.8% -0.19%
=========================================
Files 118 118
Lines 8498 8365 -133
=========================================
- Hits 7902 7763 -139
- Misses 596 602 +6
Continue to review full report at Codecov.
|
dplewis
reviewed
Dec 29, 2017
| this.connectionPromise = MongoClient.connect(encodedUri, this._mongoOptions).then(database => { | ||
| this.connectionPromise = MongoClient.connect(encodedUri, this._mongoOptions).then(client => { | ||
| // Starting mongoDB 3.0, the MongoClient.connect don't return a DB anymore but a client | ||
| // Fortunatelu, we can get back thr options |
Member
There was a problem hiding this comment.
There are a few typos in your comments. Also are you going to bump this to 3.0.1 for the index improvements?
Contributor
There was a problem hiding this comment.
Yep after this one lands.
Contributor
|
@dplewis it’s good for you? |
Contributor
|
You too! |
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
* fix(package): update mongodb to version 3.0.0 * Compatibility with MongoDB client 3.0 * Updates Gridstore as well * Set Read preference to Primary when not specified, to match original implementation * Update MongoStorageAdapter.js * Bumps to 3.0.1
This was referenced Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.0.0 of mongodb was just published.
The version 3.0.0 is not covered by your current version range.
If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of mongodb.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
Commits
The new version differs by 404 commits ahead by 404, behind by 17.
0a8b6d43.0.06eede98test(crud): update to latest specs #162244373f3refactor(collection): removegeoNearcommand helper3f69250test(cursor): testcursorsKilledas Long and Numberfa0fbc0test(sharded): fix sharded tests now that they run again84457ecfix(aggregate): remove support for inline results for aggregate (#1620)35d2d3etest(environment): modernize code, make setup asynchronousa35df4frefactor(environments): modernize and subclassEnvironmentBase0b1a17bdocs(README): Updating readme to refer to CHANGES_3.0.0.md (#1617)4ced72bdocs(FindOperatorsUnordered): updating return types to self (#1619)2c35d76docs(api): fixing all examples in API documentation (#1616)ed80d73chore(assign): replace assign with native Object.assign (#1618)0fb4658fix(topologies): unify topologies connect API (#1615)018c496refactor(utils): fix typo in lib/utils.js89c20d4refactor(mongo_client): fix typos in lib/mongo_client.jsThere are 250 commits in total.
See the full diff
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 🌴