Fixes issue #4150: Session management #4152
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4152 +/- ##
==========================================
+ Coverage 92.13% 92.17% +0.04%
==========================================
Files 116 116
Lines 8044 8051 +7
==========================================
+ Hits 7411 7421 +10
+ Misses 633 630 -3
Continue to review full report at Codecov.
|
|
Hi @flovilmart We have been testing this fix on our own server and have found two things:
With your fix and this change we are unable to reproduce issue #4150. |
|
@miguel-s thanks for debunking it, do you wanna make a PR on my PR with the additional tests so we can merge it? |
* add tests * provide fix * remove console.log
|
@natanrolnik , can you have a look? |
| user: Parse._encode(user) | ||
| } | ||
| }) | ||
| }).then(done).catch(done.fail); |
There was a problem hiding this comment.
you don't need the catch after the done since you catch up a level....
There was a problem hiding this comment.
right it was just to be safe, I can remove.
No description provided.