Fixed a Postgres Adapter issue where putting 'false' value to 'where …

[Hinaser]

…' clause in Query always raises an error

Fixed a bug where REST Query like below always fails when using Postgresql Adapter.

GET /parse/classes/sometbl/?where={"col1": {"$eq": false}}

[codecov]

Codecov Report

Merging #4100 into master will decrease coverage by 0.03%.
The diff coverage is 62.5%.

@@            Coverage Diff             @@
##           master    #4100      +/-   ##
==========================================
- Coverage   90.71%   90.68%   -0.04%     
==========================================
  Files         116      116              
  Lines        7916     7920       +4     
==========================================
+ Hits         7181     7182       +1     
- Misses        735      738       +3

Impacted Files	Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js	96.03% <62.5%> (-0.47%)	⬇️
src/RestWrite.js	93.16% <0%> (+0.18%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c059f...3e64ef4. Read the comment docs.

[flovilmart]

Can we add a test for that? Otherwise code looks great!

[Hinaser]

Hi!
Thank you for reviewing!

I think increasing test coverage is great.
I m not much sure how to write testing code.
What do you mean 'can we' here?
Does 'we' imply 'me myself'?

[flovilmart]

Hi @Hinaser !

I think increasing test coverage is great.

It's not about increasing coverage, but make sure this case is correctly handled and covered now and more importantly for the future.

 I m not much sure how to write testing code.

Have a look into the spec folder, particularly ParseQuery.spec.js, that should be straightforward from there to add a test that covers this where clause, if you need more pointers / examples LMK.

Does 'we' imply 'me myself'?

Oh no! It implies the whole community that would benefit from having this issue properly fixed and covered by a test 😉

[Hinaser]

Sorry for late.
I'm interested in writing testing script.
I'll posting the codes after my other tasks are done.

[flovilmart]

@Hinaser ping?

[dplewis]

Closing as supersed by #4667