Update uws to the latest version 🚀 #4078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4078 +/- ##
=======================================
Coverage 90.73% 90.73%
=======================================
Files 116 116
Lines 7937 7937
=======================================
Hits 7202 7202
Misses 735 735Continue to review full report at Codecov.
|
acinader
reviewed
Aug 10, 2017
Contributor
acinader
left a comment
acinader
left a comment
There was a problem hiding this comment.
something is wrong here. Why skip from 0.14.5 to 8.14.1?
acinader
approved these changes
Aug 26, 2017
Contributor
acinader
left a comment
acinader
left a comment
There was a problem hiding this comment.
ok, looked into it. the project has no change log and no mention of the big version number skip, but all looks legit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 8.14.1 of uws just got published.
The version 8.14.1 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of uws.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴