Add Babel.js compiler support. #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @drew-gross |
nlutsenko
force-pushed
the
nlutsenko.babel
branch
from
3e06b3f to
1a74f7e
Compare
Contributor
|
Seems solid to me, just two things: This probably warrants an update to CONTRIBUTING.md, and, is the removal of the commas after the last key of object due to babel? Those work fine in the dashboard, I think they should be fine here as well. |
Contributor
Author
|
Yup, you are right. |
nlutsenko
force-pushed
the
nlutsenko.babel
branch
from
1a74f7e to
0582866
Compare
nlutsenko
force-pushed
the
nlutsenko.babel
branch
from
0582866 to
9ce90b0
Compare
|
@nlutsenko updated the pull request. |
Contributor
Author
|
W00t, finally have everything running. Waiting for tests and merging then. |
|
@nlutsenko updated the pull request. |
nlutsenko
added a commit
that referenced
this pull request
Feb 9, 2016
Add Babel.js compiler support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally unblocks us from using fancy new things like ES6 and friends.
Also, there was a looot of invalid JavaScript here and there, which Babel compilation enforces to be valid - that's fixed as well.