Skip to content

Injected the username when password has changed. #3033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2016
Merged

Injected the username when password has changed. #3033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c55c67
Injected the username when password has changed.
HQarroum Nov 10, 2016
bb2932b
Update unit test for password_reset_success redirect
HQarroum Nov 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/ValidationAndPasswordsReset.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,7 @@ describe("Custom Pages, Email Verification, Password Reset", () => {
return;
}
expect(response.statusCode).toEqual(302);
expect(response.body).toEqual('Found. Redirecting to http://localhost:8378/1/apps/password_reset_success.html');
expect(response.body).toEqual('Found. Redirecting to http://localhost:8378/1/apps/password_reset_success.html?username=zxcv');

Parse.User.logIn("zxcv", "hello").then(function(user){
let config = new Config('test');
Expand Down
3 changes: 2 additions & 1 deletion src/Routers/PublicAPIRouter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,10 @@ export class PublicAPIRouter extends PromiseRouter {
}

return config.userController.updatePassword(username, token, new_password).then((result) => {
let params = qs.stringify({username: username});
return Promise.resolve({
status: 302,
location: config.passwordResetSuccessURL
location: `${config.passwordResetSuccessURL}?${params}`
});
}, (err) => {
let params = qs.stringify({username: username, token: token, id: config.applicationId, error:err, app:config.appName})
Expand Down