Fix null pointer includes #2657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Current coverage is 92.13% (diff: 83.33%)@@ master #2657 diff @@
==========================================
Files 100 100
Lines 12282 12282
Methods 1522 1522
Messages 0 0
Branches 2020 2020
==========================================
+ Hits 11312 11316 +4
+ Misses 970 966 -4
Partials 0 0
|
| if (object instanceof Array) { | ||
| return object.map((obj) => replacePointers(obj, path, replace)) | ||
| .filter((obj) => obj != null && obj != undefined); | ||
| .filter((obj) => typeof obj !== 'undefined'); |
Contributor
Author
There was a problem hiding this comment.
strip out undefined, and keep the nulls to match parse.com behaviour
|
@flovilmart updated the pull request - view changes |
|
👍 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2189