Skip to content

Fixes issue where info logs would appear in error logs #2647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2016
Merged

Fixes issue where info logs would appear in error logs #2647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7964d20
Reproduction of #2639
flovilmart Sep 3, 2016
dd4c22b
Make sure the error level options is enforced
flovilmart Sep 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions spec/WinstonLoggerAdapter.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,19 @@ describe('info logs', () => {
}, (results) => {
if (results.length == 0) {
fail('The adapter should return non-empty results');
done();
} else {
expect(results[0].message).toEqual('testing info logs');
done();
}
// Check the error log
// Regression #2639
winstonLoggerAdapter.query({
from: new Date(Date.now() - 500),
size: 100,
level: 'error'
}, (results) => {
expect(results.length).toEqual(0);
done();
});
});
});
});
Expand Down
7 changes: 3 additions & 4 deletions src/Adapters/Logger/WinstonLogger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,15 @@ function updateTransports(options) {
delete transports['parse-server-error'];
} else if (!_.isUndefined(options.dirname)) {
transports['parse-server'] = new (DailyRotateFile)(
Object.assign({
Object.assign({}, {
filename: 'parse-server.info',
name: 'parse-server',
}, options));
transports['parse-server-error'] = new (DailyRotateFile)(
Object.assign({
Object.assign({}, {
filename: 'parse-server.err',
name: 'parse-server-error',
level: 'error'
}, options));
}, options, { level: 'error'}));
}

transports.console = new (winston.transports.Console)(
Expand Down