FileAdapter errors ignored

[simonbengtsson]

If a FileAdapter returns an error it is later ignored in the file router:

// FileRouter.js
}).catch((err) => {
  // err is ignored
  next(new Parse.Error(Parse.Error.FILE_SAVE_ERROR, "Could not store file"));
});

The S3Adapter for example returns an error with the following message when the keys are wrong: The request signature we calculated does not match the signature you provided. Check your key and signing method. Would it somehow be possible to propagate this error to the developer?

[simonbengtsson]

I thought of making a PR, but I'm not entirely sure what would be best here. Simply replacing the "Could not store file" message with the one from the adapter like this?

// FileRouter.js
}).catch((err) => {
  next(new Parse.Error(Parse.Error.FILE_SAVE_ERROR, err));
});

[chriscborg]

Hi @simonbengtsson - This line worked for me if it helps:

// FileRouter.js
}).catch((err) => {
  next(new Parse.Error(Parse.Error.FILE_SAVE_ERROR, 'Could not store file: ' + err));
});

So I guess your code should work as well.

[simonbengtsson]

The question I guess is how much the adapters should be able to choose what error messages get sent to the developer. Probably it makes sense to let the adapters fully decide. It will require some changes to the adapters though to make them send better formatted errors.

[flovilmart]

There will be a need in the files adapter to return a 'standard' response as for now, when you save through the GridStore adapter or the S3Adpater, the responses differs. The FilesController is ignoring that response and returning a pre-cooked one.

[simonbengtsson]

Should the goal be that every subclass of FileAdapter should return a Parse.Error that can be passed directly to the user?

[flovilmart]

that would be nice to have something standard yes, doesn't have to be a Parse.Error as the *Controller is responsible for formatting

[parthtiwari65]

Where can I find the file, " FileRouter.js " to make these changes?

I don't see this file in my Parse server copy.

[hawkit]

@flovilmart I have changed FileRouter.js as following : next(new Parse.Error(Parse.Error.FILE_SAVE_ERROR, 'Could not store file: ' + err)); at EC2 instance. but why i still get same error as

[Error]: Could not store file. (Code: 130, Version: 1.12.0)

Do I need to restart EBS to make it work?

[jdzorz]

@parthtiwari65 it is under node_modules/parse-server/lib/controllers/FilesController.js

@hawkit yes restart your EBS

[hawkit]

@parthtiwari65 it is here: /var/app/current/node_modules/parse-server/lib/Routers/FilesRouter.js

[hawkit]

@jdzorz thanks a lot. It works!

[wavo89]

I'm using Heroku- how do I make sure that this change is active on the server? When I changed it and went to git add/commit/push, it said that there weren't any changes to save.