Skip to content

Update parse #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2019
Merged

Update parse #146

merged 2 commits into from
Oct 3, 2019

Conversation

@davimacedo
Copy link
Member

@davimacedo davimacedo commented Oct 2, 2019

Close #145

@davimacedo davimacedo mentioned this pull request Oct 2, 2019
Closed
@codecov
Copy link

codecov bot commented Oct 2, 2019 •
edited
Loading

Codecov Report

Merging #146 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #146   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         266    267    +1     
=====================================
+ Hits          266    267    +1
Impacted Files Coverage Δ
src/GCM.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f8f9ff...f221c58. Read the comment docs.

acinader
acinader previously approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

acinader
acinader reviewed Oct 2, 2019
View reviewed changes
funkenstrahlen
funkenstrahlen reviewed Oct 3, 2019
View reviewed changes
Copy link
Contributor

@funkenstrahlen funkenstrahlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Using map at this one marked place would be nice.

@davimacedo
Copy link
Member Author

davimacedo commented Oct 3, 2019

Thanks guys. I've just improved with map. Can one of you guys take a look again just to make sure?

@davimacedo davimacedo merged commit f04276c into master Oct 3, 2019
@davimacedo davimacedo deleted the update-parse-2.7.1 branch October 3, 2019 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dplewis dplewis Awaiting requested review from dplewis

@funkenstrahlen funkenstrahlen Awaiting requested review from funkenstrahlen

1 more reviewer

@acinader acinader acinader approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update parse JS SDK version in package.json?

4 participants

@davimacedo @funkenstrahlen @acinader