Skip to content

Conversation

@romanbsd
Copy link

@romanbsd romanbsd commented Aug 19, 2021

New Pull Request Checklist

  • [ x] I am not disclosing a vulnerability.
  • [ x] I am creating this PR in reference to an issue.

Issue Description

Update code to the current versions of 3rd party dependencies and standards.
Related issue: #1679

Approach

Following current React practices

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@mtrezza
Copy link
Member

mtrezza commented Aug 24, 2021

Thanks for opening this PR!

I think we discussed this already somewhere, but switching to yarn is something we would need to look at, because of potential CI implications and cross-repo compatibility (we don't use it anywhere else to my knowledge). Maybe to break this down into smaller packages, I would stick with npm for the time being and discuss a potential move to yarn in a separate issue.

@romanbsd
Copy link
Author

I can probably switch back to npm. There was some problem which I think was resolved since then.

@mtrezza
Copy link
Member

mtrezza commented Aug 24, 2021

That would be good.

@mtrezza mtrezza changed the title Fix warnings refactor: remove warnings by upgrading dependencies Sep 19, 2021
@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza
Copy link
Member

mtrezza commented Sep 19, 2021

@romanbsd There are a bunch of conflicts here, would you want to switch from yarn to npm and resolve these? Then I would take care of testing the dashboard.

@mtrezza mtrezza mentioned this pull request Oct 20, 2021
5 tasks
@mtrezza mtrezza marked this pull request as draft October 20, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants