Skip to content

Changing semver package import #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Changing semver package import #1444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dashboard/Data/Browser/AddColumnDialog.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import Parse from 'parse'
import React from 'react';
import semver from 'semver';
import semver from 'semver/preload.js';
import Dropdown from 'components/Dropdown/Dropdown.react';
import Field from 'components/Field/Field.react';
import Label from 'components/Label/Label.react';
Expand Down
8 changes: 4 additions & 4 deletions src/dashboard/Data/Config/ConfigDialog.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import TextInput from 'components/TextInput/TextInput.react';
import Toggle from 'components/Toggle/Toggle.react';
import validateNumeric from 'lib/validateNumeric';
import styles from 'dashboard/Data/Browser/Browser.scss';
import semver from 'semver';
import semver from 'semver/preload.js';

const PARAM_TYPES = [
'Boolean',
Expand Down Expand Up @@ -233,13 +233,13 @@ export default class ConfigDialog extends React.Component {
description='Use this to configure your app. You can change it at any time.' />
}
input={EDITORS[this.state.type](this.state.value, (value) => { this.setState({ value }) })} />

{
/*
Add `Requires master key` field if parse-server version >= 3.9.0,
that is the minimum version that supports this feature.
*/
semver.valid(this.props.parseServerVersion) && semver.gte(this.props.parseServerVersion, '3.9.0')
semver.valid(this.props.parseServerVersion) && semver.gte(this.props.parseServerVersion, '3.9.0')
? <Field
label={
<Label
Expand All @@ -250,7 +250,7 @@ export default class ConfigDialog extends React.Component {
<Toggle
type={Toggle.Types.YES_NO}
value={this.state.masterKeyOnly}
onChange={(masterKeyOnly) => this.setState({ masterKeyOnly })}
onChange={(masterKeyOnly) => this.setState({ masterKeyOnly })}
additionalStyles={{ margin: '0px' }} />
}
className={styles.addColumnToggleWrapper}
Expand Down