Skip to content
This repository was archived by the owner on Aug 10, 2025. It is now read-only.

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Aug 26, 2021

Merge upstream 1.0.4

The parse-server-push-adapter points to @parse/node-gcm": "1.0.2", so I assume even when merging this PR, it won’t have any effect. We may have to add our own tag and point to that?

Thomas Vogel and others added 27 commits October 20, 2018 16:38
Failed tokens can be found with a single `filter` operation over the `registrationTokens` using the 1:1 mapping with response data. Earlier example used `map` + `filter` to achieve the same result.
…s-message

Add fcm_options as allowed params to message object
Normally there is no need to override send URI
except for testing
fix: Gcm InternalServerError should also be retied with exponential-back-off.
dependency upgrades for vulnerabilities flagged by snyk
@mtrezza mtrezza requested a review from davimacedo August 26, 2021 21:39
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mtrezza
Copy link
Member Author

mtrezza commented Aug 28, 2021

Hi @ToothlessGear, your node-gcm repository is an important module for our Parse Server. We have opened several PRs in the past to fix issues and vulnerabilities.

Would you be willing to give our organization maintainer / write access to node-gcm, so we don't have to depend on our fork anymore, because we know we can fix vulnerabilities more timely? I have also opened some issues there so we can make sure vulnerabilities are fixed faster and releases are more robust.

ToothlessGear#354
ToothlessGear#355
ToothlessGear#356

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants