Added support for iOS 15 property interruption-level #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbaker6
approved these changes
Oct 30, 2021
|
@davimacedo @TysonAndre are you able to look this over? |
TysonAndre
reviewed
Nov 14, 2021
| }, | ||
|
|
||
| set interruptionLevel(value) { | ||
| if(typeof value === "string" || value === undefined) { |
There was a problem hiding this comment.
Suggested change
| if(typeof value === "string" || value === undefined) { | |
| if (typeof value === "string" || value === undefined) { |
nit: use the same spacing used elsewhere
EDIT: oh, it was already inconsistent but if ( seems several times more common. Didn't realize that.
| describe("setInterruptionLevel", function () { | ||
| it("is chainable", function () { | ||
| expect(note.setInterruptionLevel("the-interruption-level")).to.equal(note); | ||
| expect(compiledOutput()).to.have.nested.property("aps.interruption\-level", "the-interruption-level"); |
There was a problem hiding this comment.
Suggested change
| expect(compiledOutput()).to.have.nested.property("aps.interruption\-level", "the-interruption-level"); | |
| expect(compiledOutput()).to.have.nested.property("aps.interruption-level", "the-interruption-level"); |
nit: unnecessary escaping
EDIT: oh, based on existing test case with unnecessary escaping.
Member
|
@TysonAndre since the code nits are existing one, I'm going to merge this one. Maybe we should install lint/prettier to this repo. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A copy of the PR on Netatmo#6
See more here, here and here.