Add documentation for the LDAP auth module #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomWFox
reviewed
Nov 20, 2019
Co-Authored-By: Tom Fox <[email protected]>
dplewis
suggested changes
Nov 20, 2019
I hope this resolves all issues
TomWFox
approved these changes
Nov 21, 2019
Contributor
TomWFox
left a comment
TomWFox
left a comment
There was a problem hiding this comment.
Looks good to me! As standard we’ll wait until the server pr is merged and a release is published before merging the docs pr.
Contributor
Author
|
The PR in the other repo is merged now. |
Contributor
|
👍 I’ll wait for a release to merge this. |
Contributor
|
@brodo could you resolve the merge conflict and then we'll get this in |
dplewis
approved these changes
Jan 9, 2020
Contributor
|
Thanks @dplewis :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for the LDAP auth module.