This repository was archived by the owner on Jan 26, 2021. It is now read-only.
Refactor and improve Flow typing #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
This was written before Flow got support for export and export default. We can probably just use those inline, now.
Contributor
Author
There was a problem hiding this comment.
Sadly Flow doesn't like mixing export (ES6) and module.exports (CommonJS), and ES6 modules don't allow conditional exports, it seems...
The code is sufficiently different, and it got really hard to read. Plus, Flow was (well, should've been, and will, after we fix some other things) about uninitialized variables because not all codepaths hit them
…ectStore and MutationExecutor Using 'any' at that level masks much of the type checking inside the module, which prevents us from catching bugs via Flow. Two more modules are doing this, QueryTools and SubscriptionManager, but removing 'any' there will require updating a bunch of Flow type declarations and fixing code that currently doesn't get checked, so let's save those for later.
andrewimm
added a commit
that referenced
this pull request
Jul 7, 2015
Refactor and improve Flow typing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of atomic commits (each one leaves Flow checks and unit tests passing as they were) that fix some variable naming, code readability and cleanliness issues, as well as provide a bunch of Flow type annotations.
The frequent use of
anythroughout the codebase is currently shadowing a bunch of missing type declarations, as well as violations of existing type declarations. I'd like to start un-shadowing those and fixing up the call-sites one by one. I'm fairly certain that in the end we'll have a cleaner codebase, and we might even find some bugs in the process. Either way, having Flow be able to reason about the entire codebase should help us find bugs going forward.