Skip to content

Conversation

@cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Feb 14, 2021

  • Add setDeviceToken to ParseInstallation to properly convert deviceToken to a hex String to be used by Parse Server
  • Documentation
  • Testcases
  • Changelog entry
  • Prepare for next version release (bump project, pod spec, and jazzy)
  • if #available(macOS 11.0, iOS...) doesn't work well when an older version OS is looking for a newer version than what it currently knows. This causes the SPM 11.7 (Swift 5.2) test failure. Added compiler check to work across older versions of Swift.

@codecov
Copy link

codecov bot commented Feb 14, 2021

Codecov Report

Merging #78 (e5459c0) into main (7a282e1) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   79.01%   79.13%   +0.12%     
==========================================
  Files          61       62       +1     
  Lines        4903     4936      +33     
==========================================
+ Hits         3874     3906      +32     
- Misses       1029     1030       +1     
Impacted Files Coverage Δ
Sources/ParseSwift/Internal/Data+hexString.swift 100.00% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseInstallation.swift 82.22% <100.00%> (+0.15%) ⬆️
Sources/ParseSwift/Objects/ParseObject.swift 75.94% <0.00%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a282e1...e5459c0. Read the comment docs.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Feb 14, 2021

@TomWFox can you look over the docs I added?

I still need look for the possible fix I mentioned above...

Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@cbaker6 cbaker6 merged commit ffa070f into main Feb 14, 2021
@cbaker6 cbaker6 deleted the pushNotifications branch February 14, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants