fix: broken builds from Swift 5.5.0 < Swift 5.5.2 #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
#278 enabled backwards compatibility of async/await functionality on iOS 13 and alike from Xcode 13.2+. This backwards compatibility isn't available on Xcode 13.0 and 13.1, preventing the Swift SDK from building on those versions of Xcode.
Related issue: #n/a
Approach
Change the Swift version check to a compiler check and only build async/await functionality on code being compiled with 5.5.2+.
Note: For some reason, Windows CI build fails to run XCTests on Swift 5.5.2. It's a known issue on Swift Windows, so I'm leaving the windows CI on 5.5.1 for now. Opened a PR to check MaxDesiatov/swift-windows-action#1
TODOs before merging