Skip to content

Conversation

@cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jan 1, 2022

New Pull Request Checklist

Issue Description

Currently, developers have to manually create an authData dictionary with the correct credentials to login or link user accounts. This can be more error prone and makes it harder to unlink users.

Related issue: #55

Approach

Add auth support for the Github, Google, and Linkedin, similar to the other authentication methods. Completion block test cases aren't needed anymore as those methods get tested automatically when the async/await and Combine methods are tested.

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 1, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Jan 1, 2022

Codecov Report

Merging #307 (6a1104a) into main (3bf2471) will increase coverage by 0.68%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
+ Coverage   83.87%   84.56%   +0.68%     
==========================================
  Files         105      114       +9     
  Lines       11256    11661     +405     
==========================================
+ Hits         9441     9861     +420     
+ Misses       1815     1800      -15     
Impacted Files Coverage Δ
...cation/3rd Party/ParseApple/ParseApple+async.swift 100.00% <ø> (ø)
...tion/3rd Party/ParseApple/ParseApple+combine.swift 100.00% <ø> (ø)
...thentication/3rd Party/ParseApple/ParseApple.swift 82.50% <ø> (ø)
.../3rd Party/ParseFacebook/ParseFacebook+async.swift 100.00% <ø> (ø)
...rd Party/ParseFacebook/ParseFacebook+combine.swift 100.00% <ø> (ø)
...cation/3rd Party/ParseFacebook/ParseFacebook.swift 100.00% <ø> (ø)
...on/3rd Party/ParseTwitter/ParseTwitter+async.swift 100.00% <ø> (ø)
.../3rd Party/ParseTwitter/ParseTwitter+combine.swift 100.00% <ø> (ø)
...tication/3rd Party/ParseTwitter/ParseTwitter.swift 100.00% <ø> (ø)
...Authentication/Protocols/ParseAuthentication.swift 72.44% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf2471...6a1104a. Read the comment docs.

@cbaker6 cbaker6 merged commit fdbb1d9 into parse-community:main Jan 1, 2022
@cbaker6 cbaker6 deleted the authUpdates branch January 1, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant