Improve performance of string from date creation. #591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves creation of string from dates by ~5 times, by using sqlite directly instead of generic NSDateFormatter.
As a result of this improvement:
Contributes to #32, as it improves LDS perf.
Now, onto notes - I intentionally am not resetting the binding on the statements,
as there is slight performance gain there (about 5% compared to resetting them every time).
Couldn't come up with implications on not doing this, as I feel it's safe to do it in this use-case.