Skip to content

ci: Optimize CI workflow performance #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2023
Merged

ci: Optimize CI workflow performance #1724

merged 3 commits into from
Mar 10, 2023

Conversation

@dplewis
Copy link
Member

@dplewis dplewis commented Mar 10, 2023 •
edited
Loading

New Pull Request Checklist

Issue Description

The current ci workflow doesn't allow for an easy way to debug failing tests. The PR saves ~10 minutes of CI time, allows for easier debugging of flaky tests and fixes some flaky tests

Closes: #1634

Approach

  • Refactor all test jobs into a matrix
  • Run tests against iPhone 14 simulator
  • Run tests against Xcode 14
  • Ensure Ruby Gem Cache works
  • Add Carthage Cache
  • Upload test logs to artifacts to debug failing tests
  • Use XCODEBUILD instead of XCPRETTY to show more test details and derivedData folder location
  • Pin MacOS version instead of latest
  • Disabled extremely flaky tests

@parse-github-assistant
Copy link

parse-github-assistant bot commented Mar 10, 2023 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@dplewis dplewis requested review from drdaz and mtrezza March 10, 2023 02:44
@dplewis
Copy link
Member Author

dplewis commented Mar 10, 2023 •
edited
Loading

@mtrezza This should also fix the manual documentation release as well

@dplewis dplewis requested a review from davimacedo March 10, 2023 03:39
@mtrezza
Copy link
Member

mtrezza commented Mar 10, 2023 •
edited
Loading

That's really cool, waiting for the CI to pass...

@dplewis
Copy link
Member Author

dplewis commented Mar 10, 2023

@mtrezza The CI does pass. I think the old CI is trying to run.

@mtrezza mtrezza changed the title ci: Simplify workflow ci: Optimize CI workflow performance Mar 10, 2023
mtrezza
mtrezza approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit af750cf into parse-community:master Mar 10, 2023
@mtrezza mtrezza mentioned this pull request Mar 10, 2023
Closed
2 tasks
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Mar 10, 2023

🎉 This change has been released in version 2.2.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 10, 2023
@dplewis dplewis deleted the simplify-ci branch March 10, 2023 15:34
@dplewis
Copy link
Member Author

dplewis commented Mar 10, 2023

@mtrezza Can you run the manual docs generation workflow?

@mtrezza
Copy link
Member

mtrezza commented Mar 10, 2023

I did and it got published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtrezza mtrezza mtrezza approved these changes

@drdaz drdaz Awaiting requested review from drdaz

@davimacedo davimacedo Awaiting requested review from davimacedo

Assignees

No one assigned

Labels

state:released Released as stable version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dplewis @mtrezza @parseplatformorg