Skip to content

Full Text Search Query #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2017
Merged

Full Text Search Query #1196

merged 2 commits into from
Nov 17, 2017

Conversation

@dplewis
Copy link
Member

@dplewis dplewis commented Oct 1, 2017

flovilmart
flovilmart previously requested changes Oct 1, 2017
View reviewed changes
Parse/PFQuery.h
@param value the substring that the value must contain.
@return The same instance of `PFQuery` as the receiver. This allows method chaining.
*/
Copy link
Contributor

@flovilmart flovilmart Oct 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call it matchesText instead of fullText?

Copy link
Member Author

@dplewis dplewis Oct 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@flovilmart
Copy link
Contributor

flovilmart commented Oct 1, 2017

Awesome! Let’s make a plan for the 3.0 release so we can release everything at once :)

@dplewis
Copy link
Member Author

dplewis commented Oct 1, 2017

Works for me

@rihadavid rihadavid mentioned this pull request Oct 13, 2017
Closed
@rogerhu rogerhu mentioned this pull request Oct 13, 2017
Closed
@dplewis dplewis mentioned this pull request Oct 18, 2017
Closed
@montymxb
Copy link

montymxb commented Nov 3, 2017

Looks like this is just about good, and the requested changes have been added some time ago now...I'll assign myself and give this a better look in a bit.

@montymxb montymxb dismissed flovilmart’s stale review November 3, 2017 05:37

requested changes were made

@montymxb montymxb self-assigned this Nov 3, 2017
montymxb
montymxb approved these changes Nov 3, 2017
View reviewed changes
Copy link

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, was just comparing this against what you submitted over for #333 and this looks good 👍 .

@flovilmart removed your old review but if you have any additional thoughts let me know. Looks like we're ready to merge this in though.

@johnantoni
Copy link
Contributor

johnantoni commented Nov 16, 2017

Hi @montymxb as the changes have been approved can we get this one merged in?

@montymxb
Copy link

montymxb commented Nov 17, 2017

@johnantoni Yes we can! Seems we didn't follow up after approval...

@montymxb montymxb merged commit 12f53ec into parse-community:master Nov 17, 2017
@dplewis dplewis deleted the full-text branch November 17, 2017 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@flovilmart flovilmart flovilmart approved these changes

@montymxb montymxb montymxb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@montymxb montymxb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dplewis @flovilmart @montymxb @johnantoni