Adding support for RN 0.50+ #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added other try-catch to require the correct library for React Native 0.50+, as posted on [parse-community#496](parse-community#496)
Adding support for RN 0.50+
Codecov Report
@@ Coverage Diff @@
## master #504 +/- ##
==========================================
- Coverage 84.03% 83.98% -0.05%
==========================================
Files 47 47
Lines 3801 3803 +2
Branches 869 869
==========================================
Hits 3194 3194
- Misses 607 609 +2
Continue to review full report at Codecov.
|
|
Any update on this? |
natanrolnik
approved these changes
Nov 22, 2017
natanrolnik
added a commit
that referenced
this pull request
Nov 22, 2017
This reverts commit abdad34.
natanrolnik
added a commit
that referenced
this pull request
Nov 22, 2017
Contributor
|
I'm reverting this because we need a better solution, as proposed by @flovilmart in #496 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding fix, as posted on #496