Skip to content

fix: Dot notation on JSON arrays doesn't work on PushStatus offset fields #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 28, 2024
Merged

fix: Dot notation on JSON arrays doesn't work on PushStatus offset fields #2194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d52a1a2
fix: JSON Array check on dot notation doesn't for for `PushStatus` of…
dplewis Jun 28, 2024
d0a20b0
improve tests
dplewis Jun 28, 2024
d2e8ba7
remove todo
dplewis Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/ObjectStateMutations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,8 @@ export function commitServerChanges(
typeof val === 'object' &&
!Array.isArray(val) &&
Object.keys(val).length > 0 &&
Object.keys(val).some(k => !isNaN(parseInt(k)))
Object.keys(val).some(k => !isNaN(parseInt(k))) &&
!['sentPerUTCOffset', 'failedPerUTCOffset'].includes(attr)
) {
val = Object.values(val);
}
Expand Down
18 changes: 18 additions & 0 deletions src/__tests__/ObjectStateMutations-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,24 @@ describe('ObjectStateMutations', () => {
expect(objectCache).toEqual({ items: '[{"count":20},{"count":5}]' });
});

it('can commit json array with PushStatus offset fields', () => {
const serverData = {};
const objectCache = {};
ObjectStateMutations.commitServerChanges(serverData, objectCache, {
sentPerUTCOffset: { '1': { count: 20 } },
failedPerUTCOffset: { '5': { count: 25 } },
});
// Should not transform to an array
expect(serverData).toEqual({
sentPerUTCOffset: { '1': { count: 20 } },
failedPerUTCOffset: { '5': { count: 25 } },
});
expect(objectCache).toEqual({
sentPerUTCOffset: '{"1":{"count":20}}',
failedPerUTCOffset: '{"5":{"count":25}}',
});
});

it('can generate a default state for implementations', () => {
expect(ObjectStateMutations.defaultState()).toEqual({
serverData: {},
Expand Down