fix: `Parse.Query.subscribe()` does not return a rejected promise on error in Cloud Code Triggers `beforeConnect` or `beforeSubscribe` #1490

dblythy · 2022-06-05T11:38:44Z

New Pull Request Checklist

I am not disclosing a vulnerability.
I am creating this PR in reference to an issue.

Issue Description

Cloud errors thrown from beforeConnect and beforeSubscribe will now catch, just like errors from query.find

Related issue: #1489
Closes #1489

Approach

Throws error to subscription promise if error occurs

TODOs before merging

Add tests

…uery.subscribe

…ght by query.subscribe" This reverts commit 3073b77.

…o be caught by query.subscribe"" This reverts commit bc0a576.

parse-github-assistant · 2022-06-05T11:38:47Z

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

mtrezza · 2022-06-05T15:22:40Z

Since this is a breaking change, how would you like to proceed - add a temporary Parse Server option (or maybe there is an alternative?) or wait to merge until Parse Server 6?

dblythy · 2022-06-05T15:26:24Z

Which approach do you think is best? It’s not a major issue so perhaps we can wait

mtrezza · 2022-06-05T20:09:12Z

Can you think of a way to support both for a while without making it a breaking change or adding a Parse Server option? Otherwise up to you, whatever you think is best.

Should we add this as a feature or fix? The issue is currently classified as feature.

dplewis · 2022-11-10T15:49:34Z

@dblythy @mtrezza Can we get this into the 4.0.0 release?

mtrezza · 2022-11-10T16:23:47Z

That would be good

parse-github-assistant · 2022-11-10T16:30:08Z

I will reformat the title to use the proper commit message syntax.

codecov · 2022-11-11T00:47:02Z

Codecov Report

Base: 99.93% // Head: 99.89% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (e062596) compared to base (bc04b4b).
Patch coverage: 81.81% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##            alpha    #1490      +/-   ##
==========================================
- Coverage   99.93%   99.89%   -0.04%     
==========================================
  Files          61       61              
  Lines        5966     5973       +7     
  Branches     1366     1367       +1     
==========================================
+ Hits         5962     5967       +5     
- Misses          4        6       +2

Impacted Files	Coverage Δ
src/LiveQueryClient.js	`98.99% <81.81%> (-1.01%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mtrezza

Looks good!

mtrezza

How can be best explain the "breaking" aspect of this change?

Calling Parse.Query.subscribe() will now return a rejected promise if an error is thrown in Cloud Code Triggers beforeConnect or beforeSubscribe; in previous releases a resolved promise was returned, even if subscribing failed and it was necessary to create an error.on listener to handle these errors.

Does that make sense?

dblythy · 2022-11-14T23:54:40Z

Yes, that sounds good to me

# [4.0.0-alpha.2](4.0.0-alpha.1...4.0.0-alpha.2) (2022-11-15) ### Bug Fixes * `Parse.Query.subscribe()` does not return a rejected promise on error in Cloud Code Triggers `beforeConnect` or `beforeSubscribe` ([#1490](#1490)) ([96d7174](96d7174)) ### BREAKING CHANGES * Calling `Parse.Query.subscribe()` will now return a rejected promise if an error is thrown in Cloud Code Triggers `beforeConnect` or `beforeSubscribe`; in previous releases a resolved promise was returned, even if subscribing failed and it was necessary to create an `error.on` listener to handle these errors (#1490) ([96d7174](96d7174))

parseplatformorg · 2022-11-15T02:37:38Z

🎉 This change has been released in version 4.0.0-alpha.2

parse-github-assistant · 2022-11-15T02:37:45Z

The label state:released-alpha cannot be used in combination with state:breaking.

…error in Cloud Code Triggers `beforeConnect` or `beforeSubscribe` (parse-community#1490) BREAKING CHANGE: Calling `Parse.Query.subscribe()` will now return a rejected promise if an error is thrown in Cloud Code Triggers `beforeConnect` or `beforeSubscribe`; in previous releases a resolved promise was returned, even if subscribing failed and it was necessary to create an `error.on` listener to handle these errors (parse-community#1490)

# [4.0.0-alpha.2](parse-community/Parse-SDK-JS@4.0.0-alpha.1...4.0.0-alpha.2) (2022-11-15) ### Bug Fixes * `Parse.Query.subscribe()` does not return a rejected promise on error in Cloud Code Triggers `beforeConnect` or `beforeSubscribe` ([parse-community#1490](parse-community#1490)) ([96d7174](parse-community@96d7174)) ### BREAKING CHANGES * Calling `Parse.Query.subscribe()` will now return a rejected promise if an error is thrown in Cloud Code Triggers `beforeConnect` or `beforeSubscribe`; in previous releases a resolved promise was returned, even if subscribing failed and it was necessary to create an `error.on` listener to handle these errors (parse-community#1490) ([96d7174](96d7174))

# [4.0.0-beta.1](3.5.1...4.0.0-beta.1) (2023-01-23) ### Bug Fixes * `Parse.Query.subscribe()` does not return a rejected promise on error in Cloud Code Triggers `beforeConnect` or `beforeSubscribe` ([#1490](#1490)) ([96d7174](96d7174)) * Remove support for Node <14 ([#1603](#1603)) ([bc04b4b](bc04b4b)) ### Features * Add Node 16 and 18 support ([#1598](#1598)) ([2c79a31](2c79a31)) * Add node 19 support ([8ed0fab](8ed0fab)) * Add Node 19 support ([#1643](#1643)) ([dfb5196](dfb5196)) ### Performance Improvements * Avoid CORS preflight request by removing upload listener when not used ([#1610](#1610)) ([6125419](6125419)) ### BREAKING CHANGES * Calling `Parse.Query.subscribe()` will now return a rejected promise if an error is thrown in Cloud Code Triggers `beforeConnect` or `beforeSubscribe`; in previous releases a resolved promise was returned, even if subscribing failed and it was necessary to create an `error.on` listener to handle these errors (#1490) ([96d7174](96d7174)) * This release removes support for Node versions <14 ([bc04b4b](bc04b4b))

parseplatformorg · 2023-01-23T19:10:21Z

🎉 This change has been released in version 4.0.0-beta.1

# [4.0.0](3.5.1...4.0.0) (2023-01-23) ### Bug Fixes * `Parse.Query.subscribe()` does not return a rejected promise on error in Cloud Code Triggers `beforeConnect` or `beforeSubscribe` ([#1490](#1490)) ([96d7174](96d7174)) * Remove support for Node <14 ([#1603](#1603)) ([bc04b4b](bc04b4b)) ### Features * Add Node 16 and 18 support ([#1598](#1598)) ([2c79a31](2c79a31)) * Add node 19 support ([8ed0fab](8ed0fab)) * Add Node 19 support ([#1643](#1643)) ([dfb5196](dfb5196)) ### Performance Improvements * Avoid CORS preflight request by removing upload listener when not used ([#1610](#1610)) ([6125419](6125419)) ### BREAKING CHANGES * Calling `Parse.Query.subscribe()` will now return a rejected promise if an error is thrown in Cloud Code Triggers `beforeConnect` or `beforeSubscribe`; in previous releases a resolved promise was returned, even if subscribing failed and it was necessary to create an `error.on` listener to handle these errors (#1490) ([96d7174](96d7174)) * This release removes support for Node versions <14 ([bc04b4b](bc04b4b))

parseplatformorg · 2023-01-23T19:25:26Z

🎉 This change has been released in version 4.0.0

dblythy added 4 commits June 5, 2022 20:05

fix: prevent LiveQuery override with query.select

ab5be44

fix: allow Parse.Cloud.beforeSubscribe rejections to be caught by q…

3073b77

…uery.subscribe

Revert "fix: allow Parse.Cloud.beforeSubscribe rejections to be cau…

bc0a576

…ght by query.subscribe" This reverts commit 3073b77.

Revert "Revert "fix: allow Parse.Cloud.beforeSubscribe rejections t…

5f5f363

…o be caught by query.subscribe"" This reverts commit bc0a576.

dblythy added 2 commits June 5, 2022 21:39

revert

d84b72e

add catch block

540be87

mtrezza changed the title ~~fix: allow Parse.Cloud.beforeSubscribe rejections to be caught by query.subscribe~~ fix: allow Parse.Cloud.beforeSubscribe rejections to be caught by ParseQuery.subscribe Jun 5, 2022

parse-github-assistant bot changed the title ~~fix: allow Parse.Cloud.beforeSubscribe rejections to be caught by ParseQuery.subscribe~~ fix: Allow Parse.Cloud.beforeSubscribe rejections to be caught by ParseQuery.subscribe Nov 10, 2022

mtrezza added the state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message label Nov 10, 2022

mtrezza and others added 2 commits November 10, 2022 17:31

Merge branch 'alpha' into catch-errors

f947ad5

fix tests

bfde100

dblythy added 11 commits November 11, 2022 12:13

Update ParseLiveQueryTest.js

d6808ad

Update ParseLiveQueryTest.js

871f9a4

Update ParseLiveQueryTest.js

eea0f92

Update ParseLiveQueryTest.js

b61b5e1

Update ParseLiveQueryTest.js

a8b14f0

Update ParseLiveQueryTest.js

fde2bb7

Update ParseLiveQueryTest.js

7bd8264

Update ParseLiveQueryTest.js

a99309b

Update ParseLiveQueryTest.js

e60c526

Update ParseLiveQueryTest.js

1dc35cd

Update helper.js

1d805b7

dblythy added 3 commits November 14, 2022 22:13

Update helper.js

de2335e

Update ParseLiveQueryTest.js

3362397

Update ParseLiveQueryTest.js

e062596

dblythy requested a review from a team November 14, 2022 11:23

mtrezza approved these changes Nov 14, 2022

View reviewed changes

mtrezza reviewed Nov 14, 2022

View reviewed changes

mtrezza changed the title ~~fix: Allow Parse.Cloud.beforeSubscribe rejections to be caught by ParseQuery.subscribe~~ fix: Error in Cloud Code Triggers beforeConnect or beforeSubscribe does not reject promise of Parse.Query.subscribe() Nov 15, 2022

mtrezza merged commit 96d7174 into parse-community:alpha Nov 15, 2022

parseplatformorg added the state:released-alpha Released as alpha version label Nov 15, 2022

parse-github-assistant bot removed the state:released-alpha Released as alpha version label Nov 15, 2022

dblythy deleted the catch-errors branch November 15, 2022 03:21

parseplatformorg added the state:released-beta Released as beta version label Jan 23, 2023

parseplatformorg added the state:released Released as stable version label Jan 23, 2023

Uh oh!

fix: Parse.Query.subscribe() does not return a rejected promise on error in Cloud Code Triggers beforeConnect or beforeSubscribe #1490

fix: Parse.Query.subscribe() does not return a rejected promise on error in Cloud Code Triggers beforeConnect or beforeSubscribe #1490

Uh oh!

Conversation

dblythy commented Jun 5, 2022 • edited by mtrezza Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

Uh oh!

parse-github-assistant bot commented Jun 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thanks for opening this pull request!

Uh oh!

mtrezza commented Jun 5, 2022

Uh oh!

dblythy commented Jun 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mtrezza commented Jun 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dplewis commented Nov 10, 2022

Uh oh!

mtrezza commented Nov 10, 2022

Uh oh!

parse-github-assistant bot commented Nov 10, 2022

Uh oh!

codecov bot commented Nov 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mtrezza left a comment

Choose a reason for hiding this comment

Uh oh!

mtrezza left a comment

Choose a reason for hiding this comment

Uh oh!

dblythy commented Nov 14, 2022

Uh oh!

parseplatformorg commented Nov 15, 2022

Uh oh!

parse-github-assistant bot commented Nov 15, 2022

Uh oh!

parseplatformorg commented Jan 23, 2023

Uh oh!

parseplatformorg commented Jan 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix: `Parse.Query.subscribe()` does not return a rejected promise on error in Cloud Code Triggers `beforeConnect` or `beforeSubscribe` #1490

fix: `Parse.Query.subscribe()` does not return a rejected promise on error in Cloud Code Triggers `beforeConnect` or `beforeSubscribe` #1490

dblythy commented Jun 5, 2022 •

edited by mtrezza

Loading

parse-github-assistant bot commented Jun 5, 2022 •

edited

Loading

dblythy commented Jun 5, 2022 •

edited

Loading

mtrezza commented Jun 5, 2022 •

edited

Loading

codecov bot commented Nov 11, 2022 •

edited

Loading