Skip to content

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Aug 5, 2020

issue templates changed according to recent changes in parse server:

changed specifically here:

  • removed the "add test case", because from recent issues it was apparent that most authors do not (know how to?) create tests cases; we also don't have this in the parse server issue template.

@mtrezza mtrezza marked this pull request as draft August 5, 2020 23:43
@mtrezza
Copy link
Member Author

mtrezza commented Aug 5, 2020

@TomWFox How did you add the "Report a vulnerability" item in the issue list in parse server? I couldn't see anything in the .github folder regarding this.

@TomWFox
Copy link
Contributor

TomWFox commented Aug 7, 2020

Report a vulnerability is there by default if you have a SECURITY.md file

@mtrezza mtrezza marked this pull request as ready for review August 7, 2020 22:00
@mtrezza mtrezza requested review from TomWFox and dplewis August 7, 2020 22:01
TomWFox
TomWFox previously approved these changes Aug 8, 2020
Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@TomWFox
Copy link
Contributor

TomWFox commented Aug 8, 2020

Although not sure about adding a SECURITY.md file, it does pull in the one from the .github repo (and add the link in the issue type chooser). From an admin perspective it's easier to keep repos pointed to the central one - I made like 20+ PRs to change the email address in the code of conduct doc.

@mtrezza
Copy link
Member Author

mtrezza commented Aug 8, 2020

I'll wait for @dplewis as a frequent wanderer of the JS SDK issue list to get his approval.

@mtrezza
Copy link
Member Author

mtrezza commented Aug 8, 2020

Although not sure about adding a SECURITY.md file.

Absolutely, my bad, we talk about deduplication in the docs and here I duplicate 🤦‍♂️ I'll point to the existing file and remove this one.

Edit: but how would I point to the existing file?

dplewis
dplewis previously approved these changes Aug 8, 2020
Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frequent wanderer

I like that

@mtrezza mtrezza marked this pull request as draft August 8, 2020 13:24
@TomWFox
Copy link
Contributor

TomWFox commented Aug 8, 2020

Github magic will do that for you - if you look at the current issue list report a vulnerability is already an option - I think the only prerequisite is to have more than one issue template (so that the issue list shows up when you click new issue)

This reverts commit 401bbff.
@mtrezza mtrezza dismissed stale reviews from dplewis and TomWFox via d2dabed August 15, 2020 01:29
@mtrezza mtrezza marked this pull request as ready for review August 15, 2020 01:30
@mtrezza
Copy link
Member Author

mtrezza commented Aug 15, 2020

Alright, removed the securities file, I think this is ready for review.

@TomWFox TomWFox merged commit ad00118 into parse-community:master Aug 15, 2020
@mtrezza mtrezza deleted the change-github-templates branch October 26, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants