-
-
Notifications
You must be signed in to change notification settings - Fork 735
Allow setting of max retries #782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
+10 for removing ParsePlugins.Android, such a headache. Looks good to me. |
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
============================================
- Coverage 53.42% 53.34% -0.08%
- Complexity 1748 1749 +1
============================================
Files 132 132
Lines 10295 10267 -28
Branches 1428 1426 -2
============================================
- Hits 5500 5477 -23
+ Misses 4340 4337 -3
+ Partials 455 453 -2
Continue to review full report at Codecov.
|
If I get time, I'll check this out. @Jawnnypoo Wanted to let you know that this was on my (long) TODO list and I'm glad you submitted a PR for this! 👍 |
@addisonElliott if you can check it out that would be much appreciated =) |
Looks good to me. I pulled it locally and tested it out. On a sidenote, what is the purpose of |
* Remove ParsePlugins abstraction to Android, since that is our only target * Remove obsolete setting of system properties * Remove references to enabling/disable retry on command since all are retry enabled * Use max retries from configuration * Use the same default max retries as ParseRequest
Presently, the number of retries of a Parse command is always set to 5, and is not changeable. This allows you to set the number of max retries via the Parse.Configuration. Example:
or even disable retries by setting
maxRetries(0)